- Restrict meetingPassword field so it isn't leaked via the public REST/GraphQL API - Fix booking slot computation to use Europe/Berlin time instead of the server's UTC clock - Reset email verification when a customer changes their email address - Fix ICS calendar injection via unescaped carriage returns in event descriptions - Bind WebRTC meeting kicks to a persistent client id so they survive a rejoin - Move the meeting signaling token out of the WebSocket query string into the first message - Prevent duplicate signaling connections from leaking when the same participant reconnects - Use the rightmost X-Forwarded-For entry for rate limiting (single trusted reverse proxy) - Use constant-time comparison for the cron endpoint's bearer token - Remove SVG from allowed Media upload types (stored-XSS risk, unused anyway) - Add baseline security headers and a CSP to next.config.ts - Fix CI/CD script injection via unsanitized git ref names in release.yml
143 lines
5.9 KiB
YAML
143 lines
5.9 KiB
YAML
name: Release
|
|
|
|
on:
|
|
push:
|
|
tags:
|
|
- 'v*'
|
|
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
container:
|
|
image: node:22-alpine
|
|
# NODE_ENV is deliberately NOT set at job level: `npm ci` treats a
|
|
# production NODE_ENV as `--omit=dev`, which would skip eslint/
|
|
# typescript/etc. and break Lint/Typecheck/Test. It's scoped to the
|
|
# Build step below instead.
|
|
env:
|
|
NEXT_TELEMETRY_DISABLED: "1"
|
|
DATABASE_URI: postgresql://ci:ci@localhost:5432/ci
|
|
PAYLOAD_SECRET: ci-only-not-a-real-secret
|
|
MEETING_SESSION_SECRET: ci-only-not-a-real-secret
|
|
ANALYTICS_SALT_SECRET: ci-only-not-a-real-secret
|
|
CRON_SECRET: ci-only-not-a-real-secret
|
|
NEXT_PUBLIC_SERVER_URL: http://localhost:3000
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- run: apk add --no-cache libc6-compat
|
|
- run: npm ci
|
|
- run: npm run lint
|
|
- run: npx next typegen && npx tsc --noEmit
|
|
- run: npm test
|
|
- run: npm run build
|
|
env:
|
|
NODE_ENV: production
|
|
|
|
build-and-deploy:
|
|
needs: test
|
|
runs-on: ubuntu-latest
|
|
# The anouma-runner runs as a Docker container itself (gitea/runner:3),
|
|
# with the host's docker.sock bind-mounted in but no `docker` CLI binary
|
|
# of its own — a job with no `container:` here runs directly inside that
|
|
# minimal runner image and gets "docker: command not found".
|
|
#
|
|
# A plain `docker:27-cli` image (Alpine, no Node.js) doesn't work either:
|
|
# actions/checkout@v4 is a JS action and needs a Node runtime in the job
|
|
# container, which that image doesn't have — it failed at Checkout with
|
|
# exit 127. Using a Node image as the base guarantees Node is already
|
|
# there (same reason the `test` job's node:22-alpine works), and the
|
|
# Docker CLI + ssh client are added via apt. The runner auto-mounts the
|
|
# same host docker.sock into this container (sibling containers — see
|
|
# container.docker_host in the runner's config.yaml), so `docker
|
|
# build`/`push` operate on the host's real Docker daemon.
|
|
container:
|
|
image: node:22-bookworm-slim
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Install Docker CLI and ssh client
|
|
run: |
|
|
apt-get update
|
|
apt-get install -y --no-install-recommends docker.io openssh-client
|
|
rm -rf /var/lib/apt/lists/*
|
|
|
|
- name: Determine image tags
|
|
id: image
|
|
# Gitea Actions' runner is protocol-compatible with GitHub Actions,
|
|
# so step commands use the same $GITHUB_OUTPUT / $GITHUB_ENV
|
|
# mechanism (the `gitea.*` vs `github.*` expression contexts are
|
|
# just aliases of each other for `${{ }}` templating).
|
|
#
|
|
# The tag name (github.ref_name / $GITHUB_REF_NAME) is
|
|
# attacker-influenced: anyone with tag-push rights controls it, and
|
|
# git allows shell metacharacters in tag names. It's read here via
|
|
# the automatic $GITHUB_REF_NAME env var rather than `${{ github.ref_name }}`
|
|
# so its value reaches bash as data (argv/envp), never spliced into
|
|
# the script text — `${{ }}` expressions are substituted into the
|
|
# YAML before bash ever sees the script, which is what makes
|
|
# interpolating attacker-controlled values that way a script-injection
|
|
# vector (arbitrary code execution in a job that holds the registry
|
|
# and production deploy credentials).
|
|
run: |
|
|
echo "registry=${REGISTRY:-git.maro.run}" >> "$GITHUB_OUTPUT"
|
|
echo "repo=${REGISTRY_REPO:-maro/anouma}" >> "$GITHUB_OUTPUT"
|
|
echo "version=$GITHUB_REF_NAME" >> "$GITHUB_OUTPUT"
|
|
env:
|
|
REGISTRY: git.maro.run
|
|
REGISTRY_REPO: maro/anouma
|
|
|
|
- name: Log in to registry
|
|
env:
|
|
REGISTRY_IMAGE: ${{ steps.image.outputs.registry }}
|
|
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
|
|
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
|
|
run: echo "$REGISTRY_PASSWORD" | docker login "$REGISTRY_IMAGE" -u "$REGISTRY_USERNAME" --password-stdin
|
|
|
|
- name: Build image
|
|
env:
|
|
IMAGE: ${{ steps.image.outputs.registry }}/${{ steps.image.outputs.repo }}
|
|
VERSION: ${{ steps.image.outputs.version }}
|
|
run: docker build -t "$IMAGE:$VERSION" -t "$IMAGE:latest" .
|
|
|
|
- name: Push image
|
|
env:
|
|
IMAGE: ${{ steps.image.outputs.registry }}/${{ steps.image.outputs.repo }}
|
|
VERSION: ${{ steps.image.outputs.version }}
|
|
run: |
|
|
docker push "$IMAGE:$VERSION"
|
|
docker push "$IMAGE:latest"
|
|
|
|
- name: Deploy to production
|
|
env:
|
|
DEPLOY_HOST: ${{ secrets.DEPLOY_HOST }}
|
|
DEPLOY_PORT: ${{ secrets.DEPLOY_PORT }}
|
|
DEPLOY_USER: ${{ secrets.DEPLOY_USER }}
|
|
DEPLOY_SSH_KEY: ${{ secrets.DEPLOY_SSH_KEY }}
|
|
# Optional: pin the exact host key instead of trusting it on
|
|
# first connect (see DEPLOYMENT.md). Safe to leave unset.
|
|
DEPLOY_HOST_KEY: ${{ secrets.DEPLOY_HOST_KEY }}
|
|
VERSION: ${{ steps.image.outputs.version }}
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
umask 077
|
|
key_file="$(mktemp)"
|
|
known_hosts_file="$(mktemp)"
|
|
trap 'rm -f "$key_file" "$known_hosts_file"' EXIT
|
|
|
|
printf '%s\n' "$DEPLOY_SSH_KEY" > "$key_file"
|
|
chmod 600 "$key_file"
|
|
|
|
if [ -n "${DEPLOY_HOST_KEY:-}" ]; then
|
|
printf '%s\n' "$DEPLOY_HOST_KEY" > "$known_hosts_file"
|
|
else
|
|
ssh-keyscan -p "${DEPLOY_PORT:-22}" "$DEPLOY_HOST" > "$known_hosts_file" 2>/dev/null
|
|
fi
|
|
|
|
# The forced command in the server's authorized_keys (see
|
|
# setup.sh) ignores this and always runs deploy.sh itself — the
|
|
# string below only ever reaches it via $SSH_ORIGINAL_COMMAND.
|
|
ssh -i "$key_file" -o UserKnownHostsFile="$known_hosts_file" -p "${DEPLOY_PORT:-22}" \
|
|
"${DEPLOY_USER}@${DEPLOY_HOST}" "deploy ${VERSION}"
|