perf(resource-mapping): map resources with multiple threads

src/main/kotlin/app/revanced/patches/youtube/misc/customplaybackspeed/patch/CustomPlaybackSpeedPatch.kt

@@ -15,6 +15,7 @@ import app.revanced.patches.youtube.misc.customplaybackspeed.fingerprints.SpeedA
 import app.revanced.patches.youtube.misc.customplaybackspeed.fingerprints.SpeedLimiterFingerprint
 import app.revanced.patches.youtube.misc.customplaybackspeed.fingerprints.VideoSpeedPatchFingerprint
 import app.revanced.patches.youtube.misc.integrations.patch.IntegrationsPatch
+import app.revanced.patches.youtube.misc.mapping.patch.ResourceMappingResourcePatch
 import org.jf.dexlib2.builder.instruction.BuilderArrayPayload
 import org.jf.dexlib2.iface.instruction.NarrowLiteralInstruction
 import org.jf.dexlib2.iface.instruction.OneRegisterInstruction
@@ -27,7 +28,7 @@ import kotlin.math.roundToInt
 @Patch
 @Name("custom-playback-speed")
 @Description("Adds more video playback speed options.")
-@DependsOn([IntegrationsPatch::class])
+@DependsOn([IntegrationsPatch::class, ResourceMappingResourcePatch::class])
 @CustomPlaybackSpeedCompatibility
 @Version("0.0.1")
 class CustomPlaybackSpeedPatch : BytecodePatch(

src/main/kotlin/app/revanced/patches/youtube/misc/mapping/patch/ResourceIdMappingProviderResourcePatch.kt

@@ -1,40 +0,0 @@
-package app.revanced.patches.youtube.misc.mapping.patch
-
-import app.revanced.extensions.doRecursively
-import app.revanced.patcher.annotation.Description
-import app.revanced.patcher.annotation.Name
-import app.revanced.patcher.annotation.Version
-import app.revanced.patcher.data.impl.ResourceData
-import app.revanced.patcher.patch.PatchResult
-import app.revanced.patcher.patch.PatchResultSuccess
-import app.revanced.patcher.patch.impl.ResourcePatch
-import org.w3c.dom.Element
-
-@Name("resource-id-mapping-provider-resource-patch-dependency")
-@Description("Acts as a provider/dependency for resource mappings.")
-@Version("0.0.1")
-class ResourceIdMappingProviderResourcePatch : ResourcePatch() {
-    companion object {
-        internal lateinit var resourceMappings: List<ResourceElement>
-            private set
-    }
-
-    override fun execute(data: ResourceData): PatchResult {
-        data.xmlEditor["res/values/public.xml"].use { editor ->
-            resourceMappings = buildList {
-                editor.file.documentElement.doRecursively { node ->
-                    if (node !is Element) return@doRecursively
-                    val nameAttribute = node.getAttribute("name")
-                    val typeAttribute = node.getAttribute("type")
-                    if (node.nodeName != "public" || nameAttribute.startsWith("APKTOOL")) return@doRecursively
-                    val id = node.getAttribute("id").substring(2).toLong(16)
-                    add(ResourceElement(typeAttribute, nameAttribute, id))
-                }
-            }
-        }
-
-        return PatchResultSuccess()
-    }
-}
-
-data class ResourceElement(val type: String, val name: String, val id: Long)

src/main/kotlin/app/revanced/patches/youtube/misc/mapping/patch/ResourceMappingResourcePatch.kt

@@ -0,0 +1,73 @@
+package app.revanced.patches.youtube.misc.mapping.patch
+
+import app.revanced.patcher.annotation.Description
+import app.revanced.patcher.annotation.Name
+import app.revanced.patcher.annotation.Version
+import app.revanced.patcher.data.impl.ResourceData
+import app.revanced.patcher.patch.PatchResult
+import app.revanced.patcher.patch.PatchResultSuccess
+import app.revanced.patcher.patch.impl.ResourcePatch
+import org.w3c.dom.Element
+import java.util.*
+import java.util.concurrent.Executors
+import java.util.concurrent.TimeUnit
+
+
+@Name("resource-mapping")
+@Description("Creates a map of public resources.")
+@Version("0.0.1")
+class ResourceMappingResourcePatch : ResourcePatch() {
+    companion object {
+        internal lateinit var resourceMappings: List<ResourceElement>
+            private set
+
+        private val THREAD_COUNT = Runtime.getRuntime().availableProcessors()
+        private val threadPoolExecutor = Executors.newFixedThreadPool(THREAD_COUNT)
+    }
+
+    override fun execute(data: ResourceData): PatchResult {
+        // save the file in memory to concurrently read from
+        val resourceXmlFile = data["res/values/public.xml"].readBytes()
+
+        // create a synchronized list to store the resource mappings
+        val mappings = Collections.synchronizedList(mutableListOf<ResourceElement>())
+
+        for (threadIndex in 0 until THREAD_COUNT) {
+            threadPoolExecutor.execute thread@{
+                data.xmlEditor[resourceXmlFile.inputStream()].use { editor ->
+                    val resources = editor.file.documentElement.childNodes
+                    val resourcesLength = resources.length
+                    val jobSize = resourcesLength / THREAD_COUNT
+
+                    val batchStart = jobSize * threadIndex
+                    val batchEnd = jobSize * (threadIndex + 1)
+                    element@ for (i in batchStart until batchEnd) {
+                        // make sure to not to go out of bounds when rounding errors occur at calculating the jobSize
+                        if (i >= resourcesLength) return@thread
+
+                        val node = resources.item(i)
+                        if (node !is Element) continue
+
+                        val nameAttribute = node.getAttribute("name")
+                        val typeAttribute = node.getAttribute("type")
+
+                        if (node.nodeName != "public" || nameAttribute.startsWith("APKTOOL")) continue
+
+                        val id = node.getAttribute("id").substring(2).toLong(16)
+                        mappings.add(ResourceElement(typeAttribute, nameAttribute, id))
+                    }
+                }
+            }
+        }
+
+        threadPoolExecutor
+            .also { it.shutdown() }
+            .awaitTermination(Long.MAX_VALUE, TimeUnit.SECONDS)
+
+        resourceMappings = mappings
+
+        return PatchResultSuccess()
+    }
+}
+
+data class ResourceElement(val type: String, val name: String, val id: Long)

src/main/kotlin/app/revanced/patches/youtube/misc/playercontrols/bytecode/patch/PlayerControlsBytecodePatch.kt

@@ -11,14 +11,14 @@ import app.revanced.patcher.patch.PatchResult
 import app.revanced.patcher.patch.PatchResultSuccess
 import app.revanced.patcher.patch.annotations.DependsOn
 import app.revanced.patcher.patch.impl.BytecodePatch
-import app.revanced.patches.youtube.misc.mapping.patch.ResourceIdMappingProviderResourcePatch
+import app.revanced.patches.youtube.misc.mapping.patch.ResourceMappingResourcePatch
 import app.revanced.patches.youtube.misc.playercontrols.annotation.PlayerControlsCompatibility
 import app.revanced.patches.youtube.misc.playercontrols.fingerprints.BottomControlsInflateFingerprint
 import app.revanced.patches.youtube.misc.playercontrols.fingerprints.PlayerControlsVisibilityFingerprint
 import org.jf.dexlib2.iface.instruction.OneRegisterInstruction
 
 @Name("player-controls-bytecode-patch")
-@DependsOn([ResourceIdMappingProviderResourcePatch::class])
+@DependsOn([ResourceMappingResourcePatch::class])
 @Description("Manages the code for the player controls of the YouTube player.")
 @PlayerControlsCompatibility
 @Version("0.0.1")
@@ -28,7 +28,7 @@ class PlayerControlsBytecodePatch : BytecodePatch(
     override fun execute(data: BytecodeData): PatchResult {
         showPlayerControlsFingerprintResult = PlayerControlsVisibilityFingerprint.result!!
 
-        bottomUiContainerResourceId = ResourceIdMappingProviderResourcePatch
+        bottomUiContainerResourceId = ResourceMappingResourcePatch
             .resourceMappings
             .single { it.type == "id" && it.name == "bottom_ui_container_stub" }.id
 

src/main/kotlin/app/revanced/patches/youtube/misc/settings/bytecode/patch/SettingsPatch.kt

@@ -13,7 +13,7 @@ import app.revanced.patcher.patch.annotations.Patch
 import app.revanced.patcher.patch.impl.BytecodePatch
 import app.revanced.patcher.util.smali.toInstruction
 import app.revanced.patches.youtube.misc.integrations.patch.IntegrationsPatch
-import app.revanced.patches.youtube.misc.mapping.patch.ResourceIdMappingProviderResourcePatch
+import app.revanced.patches.youtube.misc.mapping.patch.ResourceMappingResourcePatch
 import app.revanced.patches.youtube.misc.settings.annotations.SettingsCompatibility
 import app.revanced.patches.youtube.misc.settings.bytecode.fingerprints.LicenseActivityFingerprint
 import app.revanced.patches.youtube.misc.settings.bytecode.fingerprints.ReVancedSettingsActivityFingerprint
@@ -94,7 +94,7 @@ class SettingsPatch : BytecodePatch(
 
     internal companion object {
         // TODO: hide this somehow
-        var appearanceStringId: Long = ResourceIdMappingProviderResourcePatch.resourceMappings.find {
+        var appearanceStringId: Long = ResourceMappingResourcePatch.resourceMappings.find {
             it.type == "string" && it.name == "app_theme_appearance_dark"
         }!!.id
 

src/main/kotlin/app/revanced/patches/youtube/misc/settings/resource/patch/SettingsResourcePatch.kt

@@ -9,7 +9,7 @@ import app.revanced.patcher.patch.PatchResultSuccess
 import app.revanced.patcher.patch.annotations.DependsOn
 import app.revanced.patcher.patch.impl.ResourcePatch
 import app.revanced.patches.youtube.misc.manifest.patch.FixLocaleConfigErrorPatch
-import app.revanced.patches.youtube.misc.mapping.patch.ResourceIdMappingProviderResourcePatch
+import app.revanced.patches.youtube.misc.mapping.patch.ResourceMappingResourcePatch
 import app.revanced.patches.youtube.misc.settings.annotations.SettingsCompatibility
 import app.revanced.patches.youtube.misc.settings.bytecode.patch.SettingsPatch
 import app.revanced.patches.youtube.misc.settings.framework.components.BasePreference
@@ -22,7 +22,7 @@ import java.io.Closeable
 
 @Name("settings-resource-patch")
 @SettingsCompatibility
-@DependsOn([FixLocaleConfigErrorPatch::class, ResourceIdMappingProviderResourcePatch::class])
+@DependsOn([FixLocaleConfigErrorPatch::class, ResourceMappingResourcePatch::class])
 @Version("0.0.1")
 class SettingsResourcePatch : ResourcePatch(), Closeable {